Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not convert arguments to strings unduly #1

Merged
merged 1 commit into from Dec 8, 2016
Merged

Do not convert arguments to strings unduly #1

merged 1 commit into from Dec 8, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 18, 2016

Do not convert arguments to strings unduly
f99620e 
License: MIT
Signed-off-by: Vasily Kolobkov <polezaivsani@openmailbox.org>
whyrusleeping
whyrusleeping approved these changes Nov 19, 2016
View reviewed changes
Copy link
Owner

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Though I think that its likely more performant to check if the current log level is even enabled before allocating another string via strings.Repeat (though, its probably a very minor cost)

cc @lgierth and @Kubuxu for additional review

@whyrusleeping whyrusleeping merged commit 0a5b4a6 into whyrusleeping:master Dec 8, 2016
@whyrusleeping whyrusleeping mentioned this pull request Dec 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@whyrusleeping