Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log parameters getting 'String'ed even when log level is disabled. #3383

Closed
whyrusleeping opened this issue Nov 14, 2016 · 1 comment
Closed

log parameters getting 'String'ed even when log level is disabled. #3383

whyrusleeping opened this issue Nov 14, 2016 · 1 comment
Labels
help wanted Seeking public contribution on this issue status/deferred Conscious decision to pause or backlog topic/perf Performance

Comments

@whyrusleeping
Copy link
Member

In reference to: #3378

It seems that theres an issue in https://github.com/whyrusleeping/go-logging (the base lib for ipfs/go-log). We should fix this so that arguments don't even get considered unless their log level is enabled.
@whyrusleeping whyrusleeping added the topic/perf Performance label Nov 14, 2016
@ghost ghost mentioned this issue Nov 18, 2016
Merged
@whyrusleeping whyrusleeping added the status/ready Ready to be worked label Nov 28, 2016
@whyrusleeping whyrusleeping removed the status/ready Ready to be worked label Dec 8, 2016
@whyrusleeping whyrusleeping reopened this Dec 8, 2016
@whyrusleeping whyrusleeping added the status/ready Ready to be worked label Dec 8, 2016
@whyrusleeping whyrusleeping mentioned this issue Dec 8, 2016
Closed
@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Mar 7, 2017
@Stebalien Stebalien added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Dec 18, 2018
@Stebalien
Copy link
Member

Fixed by updating go-logging.

@ajnavarro ajnavarro mentioned this issue Aug 24, 2022
Closed
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue status/deferred Conscious decision to pause or backlog topic/perf Performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @whyrusleeping