Merge effective script origin into origin #925
Conversation
|
Can you rebase? Probably my script settings stuff conflicted. |
|
Done. |
|
|
||
| <dl> | ||
| <dt>An <dfn data-export="" data-x="concept-origin-opaque-identifier">opaque identifier</dfn></dt> | ||
| <dd><p>An internal values, with no serialisation, for which the only meaningful operation is |
| @@ -78161,16 +78160,6 @@ callback <dfn>FrameRequestCallback</dfn> = void (<span>DOMHighResTimeStamp</span | |||
|
|
|||
| <dl> | |||
|
|
|||
There was a problem hiding this comment.
Wherever the below says "globally unique identifier" should probably be changed to "opaque identifier" and linked. ("unique [opaque identifier]"?)
There was a problem hiding this comment.
A unique opaque origin. I like that. Maybe that solves https://www.w3.org/Bugs/Public/show_bug.cgi?id=28675. @SimonSapin, what do you think?
There was a problem hiding this comment.
(We decided elsewhere to rename "opaque identifier" to "opaque origin".)
There was a problem hiding this comment.
"Opaque origin" sounds good. It matches what I had ended up with previously:
pub enum Origin {
/// A globally unique identifier
Opaque(OpaqueOrigin),
/// Consists of the URL's scheme, host and port
Tuple(String, Host<String>, u16)
}
|
Addressed review and a major bug. |
|
Mention https://www.w3.org/Bugs/Public/show_bug.cgi?id=28675 in the commit message. |
annevk
force-pushed
the
origin
branch
2 times, most recently
from
070c69b
to
f09563d
Compare
| <span>origin</span> that, through appropriate manipulation of the <code | ||
| data-x="dom-document-domain">document.domain</code> attribute, could be made to be <span>same | ||
| origin-domain</span> with other members of the group, but could not be made the same as members of | ||
| any other group. Each such group is a <dfn>unit of related similar-origin browsing |
There was a problem hiding this comment.
Add data-export="" here since this is being reformatted anyway.
| <p class="example">The <span data-x="Unicode serialisation of an origin">Unicode | ||
| serialisation</span> of ("<code data-x="">https</code>", "<code | ||
| data-x="">xn--maraa-rta.example</code>", null, null) is "<code | ||
| data-x="">https://maraña.example</code>".</p> | ||
|
|
||
| <p>The <dfn>ASCII serialisation of an origin</dfn> is the string obtained by applying the |
There was a problem hiding this comment.
Add data-export="" here and above.
|
Ping. |
| change as well.</p> | ||
| <ol> | ||
| <li><p>If <var>origin</var> is an <span data-x="concept-origin-opaque">opaque origin</span>, then | ||
| return <span>origin</span>.</p></li> |
This aligns our definition with that of contemporary implementations, whose origin model makes a whole lot more sense. Origins are shared across documents and have a single mutable field, called domain. Then they have two comparison operations, "same origin" and "same origin-domain". The latter is used where we used to compare effective script origins. This change also does away with the "other fields" notion of tuples. Such extensions now need to be standardized. This fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=27378 and https://www.w3.org/Bugs/Public/show_bug.cgi?id=28675.
This aligns our definition with that of contemporary implementations,
whose origin model makes a whole lot more sense.
Origins are shared across documents and have a single mutable field,
called domain. Then they have two comparison operations, "same
origin" and "same origin-domain". The latter is used where we used
to compare effective script origins.
This change also does away with the "other fields" notion of tuples.
Such extensions now need to be standardized.
This fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=27378.