add unload permissions-policy feature #7915
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
reviewed
May 17, 2022
source
Outdated
| false, then <span data-x="concept-event-fire">fire an event</span> named | ||
| <code data-x="event-unload">unload</code> at <var>document</var>'s | ||
| <span>relevant global object</span>, with <var>legacy target override flag</var> set.</p></li> | ||
| false and the "<code data-x="unload-feature">unload</code>" feature has not been disabled, then |
There was a problem hiding this comment.
"has not been disabled" is not precise spec language; you need to use the "allowed to use" algorithm on the appropriate document. Check the call sites of https://html.spec.whatwg.org/#allowed-to-use
There was a problem hiding this comment.
Thanks. I've updated this. Not sure if it's good enough yet.
fergald
force-pushed
the
unload-feature
branch
from
d653fb7
to
d0785a6
Compare
fergald
changed the title
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not at the point where it can be accepted and is currently for reference only.
Add
unloadas a feature controlled byPermissions-Policy. Unload events are not fired for documents where this feature is enabled.Explainer: https://github.com/fergald/docs/blob/master/explainers/permissions-policy-unload.md
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/infrastructure.html ( diff )