Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize and refactor modal dialogs #6330

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Modernize and refactor modal dialogs #6330

merged 2 commits into from
Jan 27, 2021

Commits on Jan 26, 2021

  1. Modernize and refactor modal dialogs 

    This contains a small bug fix, in that confirm() and prompt() said
"return" in some cases instead of "return false" or "return null" as
appropriate.

Other notable changes, all editorial, are:

* Factoring out repeated "cannot show modals" steps, which will likely
  expand over time (see e.g. #6297).
* Separating out and explaining the no-argument overload of alert().
* Passing the document through to the "printing steps", instead of just
  having them talk about "this Window object".
    @domenic
    domenic committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    cc680c3 View commit details
    Browse the repository at this point in the history

  2. "simple dialogs"

    @domenic
    domenic committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    ace73f0 View commit details
    Browse the repository at this point in the history