Disallow import() in worklets #6070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@padenot do you know if we have tests for this for audio worklets? |
annevk
approved these changes
Oct 19, 2020
I confirm this. |
|
I double-checked this spec change is aligned with Chrome implementation. For testing on WPTs, I have no ideas other than using API specific features ("Awkward communication") like |
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 19, 2020
|
I added a basic paint worklet test in web-platform-tests/wpt#26175. Any review is appreciated. I don't feel comfortable writing a test for audio worklets because they seem to use some nonstandard test harness. |
You can also use the standard harness in the normal way. |
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 10, 2020
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 17, 2020
… in paint worklets, a=testonly Automatic update from web-platform-tests Test that dynamic import() is disallowed in paint worklets Follows whatwg/html#6070. -- wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7 wpt-pr: 26175
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 18, 2020
… in paint worklets, a=testonly Automatic update from web-platform-tests Test that dynamic import() is disallowed in paint worklets Follows whatwg/html#6070. -- wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7 wpt-pr: 26175 UltraBlame original commit: 361c76d4900e19e2387730a053a29758c869f7c2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 18, 2020
… in paint worklets, a=testonly Automatic update from web-platform-tests Test that dynamic import() is disallowed in paint worklets Follows whatwg/html#6070. -- wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7 wpt-pr: 26175 UltraBlame original commit: 361c76d4900e19e2387730a053a29758c869f7c2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 18, 2020
… in paint worklets, a=testonly Automatic update from web-platform-tests Test that dynamic import() is disallowed in paint worklets Follows whatwg/html#6070. -- wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7 wpt-pr: 26175 UltraBlame original commit: 361c76d4900e19e2387730a053a29758c869f7c2
sidvishnoi
pushed a commit
to sidvishnoi/gecko-webmonetization
that referenced
this pull request
Dec 24, 2020
… in paint worklets, a=testonly Automatic update from web-platform-tests Test that dynamic import() is disallowed in paint worklets Follows whatwg/html#6070. -- wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7 wpt-pr: 26175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes w3c/css-houdini-drafts#506.
(See WHATWG Working Mode: Changes for more details.)
/webappapis.html ( diff )