[WIP] Introduce HTML Modules #4505

dandclark · 2019-04-04T18:35:05Z

Introduce HTML Modules, an extension of the ES modules system that enables importing of HTML content

Introduce HTML Module Record, a new subtype of Cyclic Module Record, along with implementations of relevant inherited abstract methods.
Introduce HTML Module Script, a new type of Script.
Introduce algorithms for creating HTML Module Record and HTML Module Script.
Rename Module Script to JS Module Script and define Module Script as a union of HTML Module Script and JS Module Script.
Modify "prepare a script" to prevent premature execution of an HTML Module's scripts.
Modify "fetch a single module script" to create an HTML Module if the right MIME type is received.
Modify the parser's quirks mode determination so that HTML Module Documents are always placed in non-quirks mode.
Modify "fetch the descendants of a module script" and "finding the first parse error" to handle HTML Modules

This is not yet ready to merge in given there are still open questions about the design, e.g. whether HTML Modules require a new MIME type. The intent here is to facilitate discussion and tease out issues that can be better found when making changes against the actual spec, with the intention of eventually merging in the updated PR once consensus has been reached on all open issues. These issues are primarily being tracked over in the w3c/webcomponents repo.

There is a corresponding PR against the ES spec here, which refactors InnerModuleInstantiation/InnerModuleEvaluation to avoid issues with HTML Module Record's different way of tracking its requested modules.

I've placed the built result of these changes here: https://dandclark.github.io/built-specs/whatwg-html/html-modules.html

/acknowledgements.html ( diff )
/infrastructure.html ( diff )
/origin.html ( diff )
/parsing.html ( diff )
/scripting.html ( diff )
/webappapis.html ( diff )

annevk

Exciting, couple early comments I found while skimming.

annevk · 2019-04-08T13:58:24Z

source

+  <ol>
+   <li><p>Create a new <span>Document</span> node <var>document</var> whose
+   <span data-x="concept-document-content-type">content type</span> is
+   <code data-x="">text/html</code> and mark it as being an <span


I'd suggest this is a TODO as well, as I hope we can agree it should match the MIME type we end up picking.

Yes, updated in latest commit.

Thanks for the early feedback!

annevk · 2019-04-08T14:00:07Z

source

+   <span data-x="concept-document-content-type">content type</span> is
+   <code data-x="">text/html</code> and mark it as being an <span
+   data-x="HTML documents">HTML document</span>.  Let <var>document</var> be in
+   <span>no-quirks mode</span>.  <var>document</var> must be considered an


"no-quirks" is the default so the main thing we have to ensure is that the parser cannot set it.

Removed the redundant no-quirks assigment here at HTML Module doc creation time.

See the initial insertion mode for the parser change that prevents the parser from switching it to quirks. I just followed the existing pattern for iframe srcdoc there.

annevk · 2019-04-08T14:00:27Z

source

+   <code data-x="">text/html</code> and mark it as being an <span
+   data-x="HTML documents">HTML document</span>.  Let <var>document</var> be in
+   <span>no-quirks mode</span>.  <var>document</var> must be considered an
+   <span>HTML module document</span>.</p></li>


Should we set the origin as well?

Yes; updated this step to assign the origin from the environent settings object retrieved from the HTML Module script.

annevk · 2019-04-08T14:01:28Z

source

+       <ol>
+        <li><p>Set <var>scriptEntry</var>.[[InlineModuleRecord]] = null.</p></li>
+
+        <li><p>Set <var>scriptEntry</var>.[[ExternalScriptURL]] = *script’s* src URL.</p></li>


This needs more formal wording.

Updated in latest commit.

annevk · 2019-04-08T14:01:41Z

source

+       <p>Otherwise:</p>
+
+       <ol>
+        <li><p>Set <var>scriptEntry</var>.[[InlineModuleRecord]] = null.</p></li>


You cannot use = like that. Seems like you want "to". (This happens more often, both above and below.)

Updated in latest commit.

littledan · 2019-04-09T10:58:06Z

source

@@ -58347,6 +58354,10 @@ o............A....e

   </li>

+   <li><p>If the element's <span>node document</span> is an <span>HTML module document</span>, then


Can script tags be dynamically added to an HTML module's document? If so, I don't understand when those scripts would be run.

With the current design, dynamically added scripts won't execute (as if they were added to a dynamic document).

For non-dynamically-added scripts: after the HTML Module document is parsed, we basically take a snapshot of it at that time and the <script> elements at that point become the HTML module's child modules in the module graph. Fiddling dynamically with the HTML Module doc's tree after that point won't affect the structure of the module graph, and won't affect which scripts are executed or the order of execution.

I split the non-normative part of this line into a separate note and modified it to try to clarify what I meant here.

I'm open to creating an issue on the whatwg/html repo if you think this is contentious or needs to be open to wider discussion. Our design philosophy so far has generally been to treat the HTML module document as an inert dynamic document except for the special bits needed to enable HTML modules to work as a non-leaf node in the module graph.

Thanks for the feedback!

annevk · 2019-07-18T06:44:39Z

@dandclark could you clarify why you closed this?

dandclark · 2019-07-18T18:14:38Z

@annevk I didn't meant to close it. I was doing something else in my fork of the whatwg repo and moved the source branch for these changes, forgetting that doing so would affect this PR, which ended up getting auto-closed due to my actions. I've restored the changes and reopened the PR.

Sorry for the noise!

I've also taken this opportunity to resolve the merge conflicts with the introduction of JSON modules.

dreamalligator · 2021-02-19T04:02:30Z

@annevk I didn't meant to close it. I was doing something else in my fork of the whatwg repo and moved the source branch for these changes, forgetting that doing so would affect this PR, which ended up getting auto-closed due to my actions. I've restored the changes and reopened the PR.

Sorry for the noise!

I've also taken this opportunity to resolve the merge conflicts with the introduction of JSON modules.

fyi, maybe it happened again.

annevk · 2021-02-19T06:46:42Z

I cannot reopen it since we have renamed the default branch after 3 Oct 2020 and because this pull request has been closed since then it did not get automatically adjusted. It's probably best to open a new pull request at this point @dandclark.

parasyte · 2021-07-04T00:13:39Z

We would love to see some action on this. Since HTML imports has been obsoleted, we desperately need to fill the gaps with purely declarative modular Web Components.

kellengreen · 2022-07-06T22:41:08Z

To echo the above comments, I too feel this would greatly aid Web Component adoption. Should this ticket PR be reopened or have we abandoned the proposal?

annevk · 2022-08-29T16:45:07Z

Since folks are not reading earlier comments I'll lock this.

dandclark mentioned this pull request Apr 4, 2019

Layering: Add GetRequestedModules() to Module Record tc39/ecma262#1501

Open

annevk added addition/proposal New features or enhancements needs tests Moving the issue forward requires someone to write tests labels Apr 8, 2019

annevk reviewed Apr 8, 2019

View reviewed changes

littledan reviewed Apr 9, 2019

View reviewed changes

dandclark closed this Jul 17, 2019

dandclark force-pushed the master branch from 71074e4 to 7fdd68a Compare July 17, 2019 23:43

dandclark reopened this Jul 18, 2019

dandclark closed this Oct 3, 2020

dandclark force-pushed the master branch from d491123 to 0337d29 Compare October 3, 2020 01:25

songhn233 mentioned this pull request Sep 24, 2021

update html_imports for explanation of html module mdn/content#9235

Closed

whatwg locked as resolved and limited conversation to collaborators Aug 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Introduce HTML Modules #4505

[WIP] Introduce HTML Modules #4505

dandclark commented Apr 4, 2019 •

edited by pr-preview bot

Loading

annevk left a comment

annevk Apr 8, 2019

dandclark Apr 12, 2019

dandclark Apr 12, 2019

annevk Apr 8, 2019

dandclark Apr 12, 2019

annevk Apr 8, 2019

dandclark Apr 12, 2019

annevk Apr 8, 2019

dandclark Apr 12, 2019

annevk Apr 8, 2019

dandclark Apr 12, 2019

littledan Apr 9, 2019

dandclark Apr 12, 2019

annevk commented Jul 18, 2019

dandclark commented Jul 18, 2019

dreamalligator commented Feb 19, 2021

annevk commented Feb 19, 2021

parasyte commented Jul 4, 2021

kellengreen commented Jul 6, 2022

annevk commented Aug 29, 2022

		@@ -58347,6 +58354,10 @@ o............A....e

		</li>

		<li><p>If the element's <span>node document</span> is an <span>HTML module document</span>, then

[WIP] Introduce HTML Modules #4505

[WIP] Introduce HTML Modules #4505

Conversation

dandclark commented Apr 4, 2019 • edited by pr-preview bot Loading

annevk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annevk commented Jul 18, 2019

dandclark commented Jul 18, 2019

dreamalligator commented Feb 19, 2021

annevk commented Feb 19, 2021

parasyte commented Jul 4, 2021

kellengreen commented Jul 6, 2022

annevk commented Aug 29, 2022

dandclark commented Apr 4, 2019 •

edited by pr-preview bot

Loading