Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum application version handling #508

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mutairibassam
Copy link
Contributor

Description (Proposed Changes)

  • Previous logic was always return false even if required version is larger than current application version. I've simply passed a flag in login() to satisfy function if statement condition.

Link to the issue :

Tests

All test passed and covered.

Checklist

Please check that the PR fulfills all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR
  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.md
  • Updated/added relevant documentation (doc comments with ///).
  • Added relevant reviewers.

@rolandgeider
Copy link
Member

Thanks for the PR, will take a look as soon as I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants