Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/app performance #444

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Abhisheksainii
Copy link
Contributor

Description (Proposed Changes)

(Please try to mention in bullet points.)

  • replacement of provider specific calls (_loadEntries) from home_tabs_screen to necessary screens [Workout, Measurement, Nutrition, Body Weight].

Link to the issue :

(Add link of the issue you have proposed changes to)

Tests

Please make sure to add tests when implementing new features.

Checklist

Please check that the PR fulfills all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR
  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.md
  • Updated/added relevant documentation (doc comments with ///).
  • Added relevant reviewers.

final weightProvider = context.read<BodyWeightProvider>();
final measurementProvider = context.read<MeasurementProvider>();
final userProvider = context.read<UserProvider>();
// final workoutPlansProvider = context.read<WorkoutPlansProvider>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should ideally be removed if now unused.

weightProvider.fetchAndSetEntries(),
measurementProvider.fetchAndSetAllCategoriesAndEntries(),
]);
// log('Loading plans, weight, measurements and gallery');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out code if not going to be used (see prev comment).

await workoutPlansProvider.fetchAndSetWorkoutPlanFull(planId);
workoutPlansProvider.setCurrentPlan(planId);
}
// log('Loading current nutritional plan');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove (see prev comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants