Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Web3js docs #3624

Closed
wants to merge 2 commits into from
Closed

Add Web3js docs #3624

wants to merge 2 commits into from

Conversation

avkos
Copy link

@avkos avkos commented Feb 21, 2024

Description

What changes are made in this PR? Is it a feature or a bug fix?

Additional Information

Before submitting this issue, please make sure you do the following.

  • Read the contributing guide
  • Added documentation related to the changes made.
  • Added or updated tests (and snapshots) related to the changes made.

Copy link

changeset-bot bot commented Feb 21, 2024

⚠️ No Changeset found

Latest commit: 2108091

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 10:59pm

@luu-alex
Copy link

Looks good

@tmm
Copy link
Member

tmm commented Mar 27, 2024

Appreciate this PR! Going to close it as Web3.js isn't popular among Wagmi users. Good news is folks will be able to reference the code in this PR if they are using Web3.js. At some point in the future, can revisit whether this is needed in the docs.

@tmm tmm closed this Mar 27, 2024
@avkos
Copy link
Author

avkos commented Mar 28, 2024

Hey @tmm,

Thanks for your consideration. I understand the rationale behind closing the PR, but I believe it's valuable to offer users the flexibility to choose their preferred tools. Providing documentation on how to use Wagmi with Web3.js could benefit those who opt for this route.

Here's a resource outlining how Wagmi can be integrated with Web3.js: Wagmi with Web3.js documentation.

By including this, we empower users with more options and ensure inclusivity within our community. Let's keep the door open for diverse approaches.

Cheers!

@avkos
Copy link
Author

avkos commented Mar 28, 2024

Also, I found a discussion that suggests there's interest in having this documentation. Hope you make the right decision, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants