Main page title: Show breaking change in VU 2024 iteration #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricDunsworth
temporarily deployed
to
github-ci
GitHub Actions
Inactive
|
Notes:
|
The visual update 2024 iteration's breaking change previously wasn't appearing.
It seems to have been related to structure issues in the JSON-LD file's "breaking" object:
* Array using curly brackets ( {...} )
* Key/value pair placed in the array (key was named "style")
This fixes it by:
* Using square brackets ( [...] ) for the array
* Replacing the "style" key with a "Style: " prefix in the value
EricDunsworth
force-pushed
the
main-page-title-iteration-vu-2024-breaking
branch
from
3d9aff4
to
89752df
Compare
EricDunsworth
temporarily deployed
to
github-ci
GitHub Actions
Inactive
duboisp
reviewed
Aug 19, 2024
duboisp
approved these changes
Aug 23, 2024
|
I confirm this is only a content change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visual update 2024 iteration's breaking change previously wasn't appearing.
It seems to have been related to structure issues in the JSON-LD file's "breaking" object:
{...})This fixes it by:
[...]) for the array