Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure afterEach execution after a test failure #598

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Conversation

wellwelwel
Copy link
Owner

@wellwelwel wellwelwel commented Jul 24, 2024

Fixes #597.


This PR also unifies it and test. There is no change for end use and it now accepts log output for describe + test.

  • Indirectly brings more transparency to the coverage process (especially for Windows).

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.13%. Comparing base (badf71a) to head (a6dfec7).
Report is 1 commits behind head on main.

Files Patch % Lines
src/modules/helpers/it.ts 98.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   99.24%   99.13%   -0.12%     
==========================================
  Files          26       26              
  Lines        2256     2189      -67     
  Branches      425      446      +21     
==========================================
- Hits         2239     2170      -69     
  Misses         17       17              
- Partials        0        2       +2     
Flag Coverage Δ
linux 97.94% <98.24%> (-0.07%) ⬇️
osx 97.94% <98.24%> (-0.07%) ⬇️
windows 99.04% <98.24%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel changed the title fix: afterEach hook doesn't runs after a test failure fix: ensure afterEach execution after a test failure Jul 25, 2024
@wellwelwel wellwelwel marked this pull request as ready for review July 25, 2024 08:02
@wellwelwel wellwelwel merged commit e6654c4 into main Jul 25, 2024
25 checks passed
@wellwelwel wellwelwel deleted the after-failure branch July 25, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

afterEach hook doesn't runs after a test failure
1 participant