Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobserber windows #37

Closed
wants to merge 3 commits into from
Closed

Jobserber windows #37

wants to merge 3 commits into from

Commits on Jan 18, 2024

  1. Configuration menu
    Copy the full SHA
    a62a3c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Configuration menu
    Copy the full SHA
    ac1dc0b View commit details
    Browse the repository at this point in the history
  2. feat: inherit jobserver from env for all kinds of runner

    External subcommands are already able to inherit the jobserver from
    env since rust-lang#10511. However, users reported that they've expected
    `cargo run` to behave the same as external subcommands.
    
    A popular example "cargo-xtask" pattern is used as scripting to run
    arbitrary tasks. Users may want to invoke `cargo run` from Make and
    expect some parallelism. This PR provides such an ability to the
    general `target.<...>.runner`, which affects `cargo test`,
    `cargo bench`, and `cargo run`.
    
    Note that this PR doesn't create any jobserver client if there is no
    existing jobserver from the environment. Nor `-j`/`--jobs` would create
    a new client. Reasons for this decision:
    
    * There might be crates don't want the jobserver to pollute their
      file descriptors, although they might be rare
    * Creating a jobsever driver with the new FIFO named pipe style is not
      yet supported as of `jobserver@0.1.26`. Once we can create a named
      pipe-based jobserver, it will be less risky and inheritance by
      default can be implemented.
    weihanglo committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    511beaa View commit details
    Browse the repository at this point in the history