Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when the Upgrade header cannot be read #2231

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Commits on Jun 16, 2024

  1. [security] Fix crash when the Upgrade header cannot be read

    It is possible that the Upgrade header is correctly received and handled
    (the `'upgrade'` event is emitted) without its value being returned to
    the user. This can happen if the number of received headers exceed the
    `server.maxHeadersCount` or `request.maxHeadersCount` threshold. In this
    case `incomingMessage.headers.upgrade` may not be set.
    
    Handle the case correctly and abort the handshake.
    
    Fixes #2230
    lpinca committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    dec10b6 View commit details
    Browse the repository at this point in the history