Skip to content
This repository has been archived by the owner on Aug 23, 2022. It is now read-only.

update deps + loosen some requirements #12

Merged
merged 4 commits into from
Jun 27, 2022
Merged

update deps + loosen some requirements #12

merged 4 commits into from
Jun 27, 2022

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Jun 25, 2022

rules:

  • for crates that are below v1.0 -> specify the precise version
  • If the code uses a feature that was added for example in X 0.3.17,
    then you should specify 0.3.17, which actually means "0.3.y where y >=
    17"
  • for crates the are above or equal v1.0 -> specify only major version
    if the crate's API is minimal and won't change between minor versions
    OR specify major&minor versions otherwise

tested with https://github.com/taiki-e/cargo-minimal-versions

rules:
- for crates that are below v1.0 -> specify the precise version
- If the code uses a feature that was added for example in X 0.3.17,
  then you should specify 0.3.17, which actually means "0.3.y where y >=
  17"
- for crates the are above or equal v1.0 -> specify only major version
  if the crate's API is minimal and won't change between minor versions
    OR specify major&minor versions otherwise

tested with https://github.com/taiki-e/cargo-minimal-versions
@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #12 (bfe15cd) into main (7d0d1fb) will decrease coverage by 32.80%.
The diff coverage is 25.00%.

@@             Coverage Diff             @@
##             main      #12       +/-   ##
===========================================
- Coverage   74.12%   41.32%   -32.81%     
===========================================
  Files          27       27               
  Lines        2292     4617     +2325     
  Branches      354      918      +564     
===========================================
+ Hits         1699     1908      +209     
- Misses        292     2381     +2089     
- Partials      301      328       +27     
Impacted Files Coverage Δ
src/compound_packet/compound_packet_test.rs 81.60% <0.00%> (+0.32%) ⬆️
src/extended_report/dlrr.rs 57.97% <ø> (+0.61%) ⬆️
src/extended_report/prt.rs 62.85% <ø> (+0.53%) ⬆️
src/extended_report/rle.rs 47.52% <ø> (-0.48%) ⬇️
src/extended_report/rrt.rs 58.00% <ø> (+0.85%) ⬆️
src/extended_report/ssr.rs 56.30% <ø> (+0.37%) ⬆️
src/extended_report/unknown.rs 0.00% <ø> (ø)
src/extended_report/vm.rs 63.71% <ø> (+0.32%) ⬆️
src/header.rs 65.57% <ø> (ø)
src/packet.rs 39.21% <ø> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d0d1fb...bfe15cd. Read the comment docs.

@melekes melekes marked this pull request as ready for review June 27, 2022 11:11
@melekes melekes merged commit 5c6e1d0 into main Jun 27, 2022
@melekes melekes deleted the anton/deps branch June 27, 2022 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant