Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json (change ws dependency to pull ^8.18.0) #5241

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

KanoYugoro
Copy link
Contributor

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

This PR addresses this package advisory: GHSA-3h5v-q93c-6h6q
Theoretically, just a rebuild of the project is necessary to fix this, but explicitly pulling this dependency helps.

Breaking Changes

Additional Info

While this advisory is theoretically a minor bug (this being a development tool), and a mitigatable one at that, it's nice to have this dependency updated to prevent consumers of this package from having to take mitigation steps other than pulling a minor/patch version.

Copy link

linux-foundation-easycla bot commented Jul 23, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.53%. Comparing base (af6bd68) to head (7764534).
Report is 67 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5241      +/-   ##
==========================================
- Coverage   90.29%   85.53%   -4.77%     
==========================================
  Files          15       16       +1     
  Lines        1577     1680     +103     
  Branches      601      628      +27     
==========================================
+ Hits         1424     1437      +13     
- Misses        140      217      +77     
- Partials       13       26      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-akait alexander-akait merged commit 0dcd2d2 into webpack:master Jul 23, 2024
38 of 41 checks passed
@KanoYugoro KanoYugoro deleted the patch-1 branch July 23, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants