-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Use listr to display progress and errors for transformations #92
Conversation
Hey @okonet - I tried out the |
@pksjce I'll take a look at conflicts. Re: not showing sub-steps: it's just too damn fast :) It will show those if it would fail though. I'll play around with it a bit more to make it even friendlier. |
Shall I merge this now? It looks like things can be built on top of this? |
Please do a review and approve/reject it and I'll merge it. |
reject(err); | ||
} | ||
try { | ||
console.time('Reading webpack config'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch that shouldn't have made through the review :( Will remove it.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
N/A
Summary
This PR introduces better progress and error messages for failing transforms.
Does this PR introduce a breaking change?
No