Feature: Use listr to display progress and errors for transformations #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenstensberg
approved these changes
Mar 19, 2017
This was referenced Mar 21, 2017
|
Hey @okonet - I tried out the |
|
@pksjce I'll take a look at conflicts. Re: not showing sub-steps: it's just too damn fast :) It will show those if it would fail though. I'll play around with it a bit more to make it even friendlier. |
|
Shall I merge this now? It looks like things can be built on top of this? |
|
Please do a review and approve/reject it and I'll merge it. |
pksjce
approved these changes
Mar 24, 2017
okonet
commented
Mar 24, 2017
| reject(err); | ||
| } | ||
| try { | ||
| console.time('Reading webpack config'); |
There was a problem hiding this comment.
Ouch that shouldn't have made through the review :( Will remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
N/A
Summary
This PR introduces better progress and error messages for failing transforms.
Does this PR introduce a breaking change?
No