-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: code of conduct #873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we move it to .github
? :)
Also, file name has a typo, please see.
Github scans the Edit: Github also suggests different template but webpack is under the OpenJS foundation (former JS Foundation). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github scans the CODE_OF_CONDUCT.md file inside the root folder of the project
Correct, proly we should move it to project root in js.org too.
Apparently, it scans |
I think it's more visible if we left it in the project root. What do you think? It's not a .github thing, it's a project thing. |
Yeah lgtm, you think linking it in the README will prove to be helpful? 🤔 |
@anshumanv Maybe from the contribution readme file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have left some of suggestions :)
@ematipico Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm 🙂
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
What kind of change does this PR introduce?
No
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Added a simple template for code of conduct. Copied from webpack.js.org
Does this PR introduce a breaking change?
No
Other information