-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(contribute): adds table of contents and info about dependencies. #842
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, it's nice to have a TOC here! I've left some comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small change
.github/CONTRIBUTING.md
Outdated
- [Your first Contribution](#your-first-contribution) | ||
- [Setup](#setup) | ||
- [Using npm](#using-npm) | ||
- [Using yarn](#using-yarn) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is not correct. Could you please check with prettier? Or an online linter? https://dlaa.me/markdownlint/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, pls join the discussion on #850
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad rebase 😅
60fb56c
to
dca8f74
Compare
dca8f74
to
73ed3c1
Compare
@pranshuchittora Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
adds table of contents and adds some information about dependencies in the project
updates the table of contents based on review
fixes linting based on markdownlint
trying to resolve merge conflicts
73ed3c1
to
b09448c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ematipico for final thoughts regarding indents
What kind of change does this PR introduce?
Docs
Motivation
package-lock.json
)Hence everything sorted 🎉