-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(init): refactored the init.ts success message #810
Conversation
now the success message is more maintainable
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
refactored init.ts to make code more readable
@pranshuchittora Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a screenshot of the fix?
@evenstensberg screenshot of changes ? |
Take a screenshot of the change |
@evenstensberg screenshot captured 👍 |
The visual change, not code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Previously there was multiple `stdout.write` due to the presence of conditional statements. In this PR I have scrapped those repeating lines into a single `process.stdout.write` <!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. --> **What kind of change does this PR introduce?** Refactoring **Did you add tests for your changes?** No **If relevant, did you update the documentation?** Can't say **Does this PR introduce a breaking change?** Probably not
Previously there was multiple
stdout.write
due to the presence of conditional statements. In this PR I have scrapped those repeating lines into a singleprocess.stdout.write
What kind of change does this PR introduce?
Refactoring
Did you add tests for your changes?
No
If relevant, did you update the documentation?
Can't say
Does this PR introduce a breaking change?
Probably not