-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve references in schema #605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks Tobias! 💙
@ematipico any reason for the fix prefix failing? |
a62d1c5
to
b977b23
Compare
@sokra Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
b977b23
to
2bf6732
Compare
bin/config-yargs.js
Outdated
} | ||
} | ||
} | ||
return schema; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this current
?
2bf6732
to
2c06cc0
Compare
Avoid to access definitions directly
2c06cc0
to
a9c9e0d
Compare
Still broken, will fix in another PR. There's some archived package to remove |
@ematipico Same CI issue is happening for #602 as well. Seems to be something related to Could be happening because due to removal of |
Yes, let's discuss it here #584 PR looks good to me! |
avoid accessing definitions directly
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
existing test should be fine
If relevant, did you update the documentation?
not relevant
Summary
refactor the way of accessing webpack's schema to not create a internal dependency on the exact structure of the schema.
Does this PR introduce a breaking change?
No
Other information
see also webpack/webpack#7232