-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(pkg): readme info #497
Conversation
Created read me file for info sub package
|
||
```bash | ||
npm i -D @webpack-cli/info | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an example to this as well, and how to use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please change base branch to
next
? Havingmaster
ahead ofnext
would causenext
to rebase and force push every timemaster
gets ahead.
@ematipico status on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll include a command section as well in the usage section, both by importing and by invoking webpack.cli
todo:
- Add invocation through webpack-cli section
- Add invocation through node section
This should be standard for all the readme files in packages
.
@ematipico Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
PTAL |
packages/info/README.md
Outdated
@@ -0,0 +1,24 @@ | |||
# webpack-cli Info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small I and otherwise good to go, thanks @ematipico !
@ematipico The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from travis (failure) and fix these issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* docs(pkg): readme info Created read me file for info sub package * docs(readme): added usage example * Updated usage * Fixed correct package * docs(info): small typo
What kind of change does this PR introduce?
Documentation. Part of #247
Did you add tests for your changes?
No
If relevant, did you update the documentation?
yes
Summary
Created read me file for info sub package
Does this PR introduce a breaking change?
No
Other information