feat: use npm ci for tests (#367) #368
Conversation
|
|
|
@ev1stensberg yes , did not notice that the used npm version is less than 5.7.0 will fix it now and push |
|
Sweet, I'll review once you're set! |
package.json
Outdated
| @@ -96,6 +96,7 @@ | |||
| "lodash": "^4.17.5", | |||
| "log-symbols": "^2.2.0", | |||
| "mkdirp": "^0.5.1", | |||
| "npm": "^5.8.0", | |||
There was a problem hiding this comment.
Dont think you need npm installed
| - commitlint-travis |
There was a problem hiding this comment.
Please don't remove newline at EOF. 😺
There was a problem hiding this comment.
I did not remove it , I added it
.appveyor.yml
Outdated
| @@ -12,7 +12,8 @@ build: off | |||
|
|
|||
| install: | |||
| - ps: Install-Product node $env:nodejs_version $env:platform | |||
| - npm install | |||
| - npm install --global npm@5.8.0 | |||
There was a problem hiding this comment.
I'd prefer to do npm i -g npm instead of locking to a version so that we always use the latest one.
|
@FadySamirSadek Thanks for your update. I labeled the Pull Request so reviewers will review it again. @dhruvdutt Please review the new changes. |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
* feat: use npm ci for tests * fix(npm version): updated npm version to support npm ci * fix(npm version): removed npm from package.json and package-lock.json
What kind of change does this PR introduce?
This PR aims to replace npm install with npm ci which speeds up module installation when using CI systems like TravisCI
Did you add tests for your changes?
No
If relevant, did you update the documentation?
Summary
Solves #367
Does this PR introduce a breaking change?
Other information