-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support --build-delimiter for opt-in output delimiter #340
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, any tools that are good to use this with? Would be nice to know!
Thanks for another quick review @ev1stensberg and @ematipico. As far as tooling, here's one slightly contrived use case: we wrote an internal tool that pipes build output to individual Slack messages for a particularly important build that sits in watch mode. This was difficult to do; we either had to use |
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
N/A
Summary
This PR introduces a new
--build-delimiter
CLI option to add opt-in support for custom text after normal build output. This feature is useful for tooling that parsesstdout
, originally arose from webpack/webpack#6002, and resolves #192.Does this PR introduce a breaking change?
No
Other information
I was unsure of the purpose of
bin/process-options.js
as it doesn't appear to be used anywhere. I noticed this file has been recently updated, so I added the CLI option to bothbin/process-options.js
andbin/webpack.js
.