cli(entry): quotes sanitization #337

dhruvdutt · 2018-03-11T18:25:02Z

What kind of change does this PR introduce?
Enhancement/fixes

Did you add tests for your changes?
Yes

Summary
Add quotes sanitization allowing inputs like "./src/index" along with './src/index'

Related #315, #331

webpack-bot · 2018-03-11T18:32:51Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

ematipico · 2018-03-11T19:19:57Z

lib/init/index.js

@@ -7,71 +7,71 @@ const pEachSeries = require("p-each-series");

 const runPrettier = require("../utils/run-prettier");

-const entryTransform = require("./transformations/entry/entry");
-const outputTransform = require("./transformations/output/output");
+const amdTransform = require("./transformations/other/amd");


Maybe we can consider these eslint rules:

https://eslint.org/docs/rules/sort-vars

https://eslint.org/docs/rules/sort-keys

Although it could be a killer eheh

Sure! I'll do it in a separate PR if we all agree on adding the rule.

evenstensberg

reviewing this properly tomorrow.

evenstensberg · 2018-03-12T10:18:52Z

lib/generators/utils/entry.js

@@ -84,7 +84,11 @@ module.exports = (self, answer) => {
 					validate
 				)
 			])
-			.then(singularAnswer => `"${singularAnswer["singularEntry"]}"`);
+			.then(singularEntryAnswer => {
+				let { singularEntry } = singularEntryAnswer;


Why is this needed?

Testing if input has " and then swapping it with '.

Looking at the test, probably to check if entry point name has \ ?

evenstensberg

I don't see why we should do this? The alphabetical order is okay, but swapping \ is not needed

webpack-bot · 2018-03-14T10:27:49Z

@dhruvdutt Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

dhruvdutt · 2018-03-14T10:34:37Z

lib/generators/utils/entry.js

 						) {
-							propAns[val] = `"${propAns[val]}.js"`;
+							entryPropAnswer[val] = `\'${entryPropAnswer[val].replace(/"|'/g,"").concat(".js")}\'`;


The quote sanitization won't affect function as entries as we have a check for it.

webpack-cli/lib/generators/utils/entry.js

Lines 64 to 72 in 8787043

if (

propAns[val].charAt(0) !== "(" &&

propAns[val].charAt(0) !== "[" &&

propAns[val].indexOf("function") < 0 &&

propAns[val].indexOf("path") < 0 &&

propAns[val].indexOf("process") < 0

) {

propAns[val] = `"${propAns[val]}.js"`;

}

ematipico · 2018-04-04T13:59:13Z

@ev1stensberg is this good for you?

evenstensberg · 2018-04-04T20:46:10Z

Needs rebase, and yes. If it works, I was insecure about the formatting around the quotes. You should test this locally before merging

evenstensberg

Could you fix the issue where if you'd write "./src/index" in multiple modules for entry, it would append .js to the string, but right now it fails.

Seems to be a prior issue, but would be nice if you'd fix it

dhruvdutt · 2018-04-15T10:24:24Z

@ev1stensberg @ematipico Can we please merge this and cover the .js part in a different PR? I'll file an issue once this is merged. :)
We can have a dicussion there what extensions we support for paths and whether we should hard bind it to .js.

evenstensberg · 2018-04-15T12:27:13Z

Yes, but fix conflicts

dhruvdutt · 2018-04-15T12:54:14Z

@ev1stensberg Resolved and rebased. PTAL.

evenstensberg

Are you using pull or rebase? Your PR's include previous people's code, hard to keep track of what changes from time to time. I'd like to see some tests

evenstensberg · 2018-04-15T13:32:49Z

lib/utils/prop-types.js

 	"recordsInputPath",
 	"recordsOutputPath",
 	"recordsPath",
-	"resolveLoader"
+	"resolve",


Bad rebase?

It includes all properties. I think Git/GitHub diff might not interpret it as sorting but only show changes in code based on line number. That's why we see such confusing diffs. You can verify it from the current file.

dhruvdutt · 2018-04-15T14:22:55Z

@ev1stensberg I'm using rebase else it would have created a merge commit. Not sure which part you're pointing that includes other people's code. I looked into the diff, seems to only have changes I've done.

About additional tests, I think the quotes sanitization would happen at generator itself and it won't let pass entry strings without quotes to transformation function. While taking input from prompt and before storing inside the yeoman configuration this would happen:

src/index => 'src/index'
"src/index" => 'src/index'
'src/index' => 'src/index'

So, the transformation function would always receive string with quotes sanitized.
Also, adding tests to generators is definitely something we have in plan. 🙂

dhruvdutt · 2018-04-16T17:50:23Z

@ematipico Can you please do a final review?

* fix(loader,plugin): fix generators path bug * cli(refactor): improve folder structure (#371) * cli(refactor): improve folder structure * chore(linting): fix linter errors * cli(filepath): use local import instead * cli(migrate): refactor error handling * chore(review): fix review comments * chore(review): fix review comments * chore(review): fix review comments * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(init): mode support to config (#364) * cli(init): mode support to config * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * cli(init): webpack4 ready (#356) * cli(init): webpack4 ready * cli(init): remove unused variable, still @next on etwp * cli(init): Allow to use default entry in `init` * cli(init): Fix typo in comment * cli(init): Optimization transform and tests * cli(init): Fix non-optimized option for splitChunks * cli(init): Add cachingGroup per entry, don't show name in prod * cli(init): Add cachingGroup's defaults, fix entry * cli(init): Add a link to where the defaults live * cli(init): Remove default caching group definition from example * Add NoEmitOnErrorsPlugin transformation (#399) * ast(migrate): handle no emit on error * ast(migrate): handle module concatenation and named modules * ast(migrate): handle module concatenation and named modules * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * cli(entry): quotes sanitization (#337) * chore: minor doc fixes * cli(entry): quotes sanitization * tests(entry): add test case for double quotes * tests(entry): update snapshots * misc(utils): entry - variable parity * misc(prop-types): sort * cli(entry): multiple entries quotes sanitization * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * cli(migration): update UglifyJS transformation (#416) * cli(migration): Update UglifyJS migration file to fit webpack4 configuration * cli(migration): Add cases where require variable does not need to exist * cli(migration): Add transformation for usage of webpack.otimization.UglifyPlugin * cli(tests): Update test snapshots after updating transformation * cli(fix): fix expressionContent being null * cli(refactor): remove plugins array if empty Created function on ast-utils so every other transformation can use this. * tests: add tests for new ast-utils method * fix: fix test names and jsdoc * fix: update maxSize for utils folder * ast(cli): Recursively parse AST (#341) * ast(refactor): wip refactor * ast(refactor): wip refactor * ast(init): refactor * test(refactor): refactor test suite * tests(define): swap args * ast(parsing): refactor stuff * ast(init): refactor * ast(init): refactor tests * chore(tests): remove some unneeded tests * chore(pkg): update package.json * chore(project): clear up project structure * chore(cli): remove unneded files * chore(git): add gitignore to yeoman file * chore(deps): update pkg.json * tests(snapshots): update snapshots * tests(jest): use empty module for snapshots * tests(snap): only test one prop * chore(publishing): add semantic-release (#415) * chore(release): [WIP] add semantic-release * test(ci): wip * test(ci): add node versions * test(ci): remove extra test * tests(ci): revise * tests(ci): only push to npm on master * tests(ci): use matrix on jobs * tests(ci): revise * tests(ci): update * tests(ci): test * tests(ci): test * tests(ci): p * tests(ci): update travis.yml * chore(release): revise travis * misc(yeoman): update yeoman * chore(travis): revise travis * misc(travis): revise travis.yml * chore(travis): remove redundant code * chore(pkg): add keywords * 2.1.1 * 2.1.2 * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(lerna): refactor * chore(lerna): refactor * chore(refactor): refactor stuff * chore(package): update pkg.lock * chore(templates): Update issue templates (#432) Adds fancy templates * ast(init): add topScope prop * ast(merge): re-add merge prop * cli(lerna): refactor * chore(lerna): refactor * chore(lerna): update * chore(lint): revise * chore(refactor): refactor * chore(tests): use lerna for tests * chore(travis): don't cache me outside * chore(pkg): remove prefer global * chore(release): v.2.1.3 * chore(package.lock): update pkg.lock * fix(loader,plugin): fix generators path bug * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * misc(yeoman): update yeoman * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(templates): Update issue templates (#432) Adds fancy templates * cli(lerna): refactor * chore(lerna): refactor * chore(pkg): remove prefer global * chore(travis): Add encrypted private ssh key * fix(pkg): test auto setup * cli(init): revise installation steps (#441) * cli(init): revise installation steps * chore(formatting): format code * cli(tests): refactor tests * chore(travis): run lockfile cmds on tests (#444) * Update dependencies to enable Greenkeeper 🌴 (#443) chore(greenkeeper): Update dependencies to enable Greenkeeper 🌴 * chore(docs): update readme * chore(travis): add Node.js 10 (#425) * chore(travis): move npm ci to install task (#424) * chore(travis): move npm ci to install task * chore: trigger new build * chore: upgrade Node.js for Appveyor to 8 * chore: remove redundanct npm install command

* chore(monorepo): move to lerna * chore(monorepo): use commands as normal instead of package * fix(revert): packagejson * chore(monorepo): prune files and update eslint rules * chore(monorepo): fix the no-missing-require error * chore(monorepo): fix typo * chore(monorepo): fix typo * chore(monorepo): prune package json * chore(monorepo): merge package lock json * chore(monorepo): updated package.json * chore(monorepo): fix plugin package.json * chore(cli): move to lerna and scoped packages (#434) * fix(loader,plugin): fix generators path bug * cli(refactor): improve folder structure (#371) * cli(refactor): improve folder structure * chore(linting): fix linter errors * cli(filepath): use local import instead * cli(migrate): refactor error handling * chore(review): fix review comments * chore(review): fix review comments * chore(review): fix review comments * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(init): mode support to config (#364) * cli(init): mode support to config * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * cli(init): webpack4 ready (#356) * cli(init): webpack4 ready * cli(init): remove unused variable, still @next on etwp * cli(init): Allow to use default entry in `init` * cli(init): Fix typo in comment * cli(init): Optimization transform and tests * cli(init): Fix non-optimized option for splitChunks * cli(init): Add cachingGroup per entry, don't show name in prod * cli(init): Add cachingGroup's defaults, fix entry * cli(init): Add a link to where the defaults live * cli(init): Remove default caching group definition from example * Add NoEmitOnErrorsPlugin transformation (#399) * ast(migrate): handle no emit on error * ast(migrate): handle module concatenation and named modules * ast(migrate): handle module concatenation and named modules * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * cli(entry): quotes sanitization (#337) * chore: minor doc fixes * cli(entry): quotes sanitization * tests(entry): add test case for double quotes * tests(entry): update snapshots * misc(utils): entry - variable parity * misc(prop-types): sort * cli(entry): multiple entries quotes sanitization * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * cli(migration): update UglifyJS transformation (#416) * cli(migration): Update UglifyJS migration file to fit webpack4 configuration * cli(migration): Add cases where require variable does not need to exist * cli(migration): Add transformation for usage of webpack.otimization.UglifyPlugin * cli(tests): Update test snapshots after updating transformation * cli(fix): fix expressionContent being null * cli(refactor): remove plugins array if empty Created function on ast-utils so every other transformation can use this. * tests: add tests for new ast-utils method * fix: fix test names and jsdoc * fix: update maxSize for utils folder * ast(cli): Recursively parse AST (#341) * ast(refactor): wip refactor * ast(refactor): wip refactor * ast(init): refactor * test(refactor): refactor test suite * tests(define): swap args * ast(parsing): refactor stuff * ast(init): refactor * ast(init): refactor tests * chore(tests): remove some unneeded tests * chore(pkg): update package.json * chore(project): clear up project structure * chore(cli): remove unneded files * chore(git): add gitignore to yeoman file * chore(deps): update pkg.json * tests(snapshots): update snapshots * tests(jest): use empty module for snapshots * tests(snap): only test one prop * chore(publishing): add semantic-release (#415) * chore(release): [WIP] add semantic-release * test(ci): wip * test(ci): add node versions * test(ci): remove extra test * tests(ci): revise * tests(ci): only push to npm on master * tests(ci): use matrix on jobs * tests(ci): revise * tests(ci): update * tests(ci): test * tests(ci): test * tests(ci): p * tests(ci): update travis.yml * chore(release): revise travis * misc(yeoman): update yeoman * chore(travis): revise travis * misc(travis): revise travis.yml * chore(travis): remove redundant code * chore(pkg): add keywords * 2.1.1 * 2.1.2 * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(lerna): refactor * chore(lerna): refactor * chore(refactor): refactor stuff * chore(package): update pkg.lock * chore(templates): Update issue templates (#432) Adds fancy templates * ast(init): add topScope prop * ast(merge): re-add merge prop * cli(lerna): refactor * chore(lerna): refactor * chore(lerna): update * chore(lint): revise * chore(refactor): refactor * chore(tests): use lerna for tests * chore(travis): don't cache me outside * chore(pkg): remove prefer global * chore(release): v.2.1.3 * chore(package.lock): update pkg.lock * fix(loader,plugin): fix generators path bug * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * misc(yeoman): update yeoman * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(templates): Update issue templates (#432) Adds fancy templates * cli(lerna): refactor * chore(lerna): refactor * chore(pkg): remove prefer global * chore(travis): Add encrypted private ssh key * fix(pkg): test auto setup * cli(init): revise installation steps (#441) * cli(init): revise installation steps * chore(formatting): format code * cli(tests): refactor tests * chore(travis): run lockfile cmds on tests (#444) * Update dependencies to enable Greenkeeper 🌴 (#443) chore(greenkeeper): Update dependencies to enable Greenkeeper 🌴 * chore(docs): update readme * chore(travis): add Node.js 10 (#425) * chore(travis): move npm ci to install task (#424) * chore(travis): move npm ci to install task * chore: trigger new build * chore: upgrade Node.js for Appveyor to 8 * chore: remove redundanct npm install command * chore(linting): resolve linter errors * chore(linting): fix linting errors * chore(linting): resolve linting * chore(linting): resolve linting * chore(scaffold): move addons to scaffold * chore(scaffold): fix linting errors * cli(prompt): initial comment for prompt file * cli(prompt): wip * fix(monorepo): fix lint errors * fix(monorepo): fix cross spawn versions * fix(monorepo): update lock files * fix(monorepo): fix versions in pacakges * chore(rebase): refactor stuff * cli(pkgs): re-add entries * chore(v): revise pkg * v0.0.1 * chore(v): revise some deps * v0.0.2 * v0.0.3 * chore(v): back to v1 * v0.0.2 * v0.0.3 * v0.0.4 * chore(deps): update deps * chore(prompt): revise prompt cmd * v0.0.5 * cli(path): resolve better * v0.0.6 * chore(v.6): update init * chore(pkg): v.6 on next * chore(monorepo): add bootstrap to run chore(monorepo): add bootstrap to ci * chore(monorepo): fix appveyor build * chore(monorepo): fix appveyor build * chore(monorepo): add eslint-plugin-prettier * chore(monorepo): fix appveyor build chore(monorepo): fix appveyor build chore(monorepo): add eslint-plugin-prettier chore(monorepo): use nohoist * chore(monorepo): fix versions and use clean bootstrap * chore(monorepo): add rimraf globally chore(monorepo): revert back * chore(monorepo): fix windows build * cli(color): don't use color on non-tty (#452) * Added yarn lock file to gitignore (#455) * chore(next): dev version bump * chore(monorepo): fix windows build * cli(symlinks): Fix paths (#453) * cli(symlinks): fix symlinks * chore(linting): resolve linting errors * chore(rebase): remove old file * cli(init): Better defaults (#451) * cli(init): set default generator name * cli(init): better defaults * chore(rebase): remove old commit * cli(init): fix broken ast and merge scaffolds * chore(docs): better defaults * chore(lint): fix linting errors * chore(deps): remove path from dep installation * chore(resolve): resolve conflicts * fix(vulnerabilities): vulnerabilities patch for v3 (#460) * chore(dependencies): fix vulnerabilities * misc(scripts): update clean:all script * chore(dependencies): fix vulnerabilities * tests(parser): fix recursive-tests signature (#470) * chore(deps): add lerna * tests(coverage): fix coverage (#473) * test(coverage): fix coverage * test(binTestCases): run bintestcases on upper-repo * tests(travis): add node 10 * tests(cov): use regular nyc on tests * chore(lockfile): update pkglock * chore(semantic): configure plugins (#475) * fix(cli): show help flag when defaults fail (#466) * fixed test cases * remove unwanted console * fix(254) - addressed PR comments * fix(254) - added requested changes at right place * fix(254) - exit after error exit webpack if defaults are not found fix test cases for no options * fix: require chalk * refactor - addressed PR comments * refactor - addressed PR comments * refactor : remove unwanted keywords * chore(review): format * tests(no-options): refactor tests * ast(parser): add (#456) * ast(parser): add, update, remove - literal node support * ast(parser): add command * ast(util): update property, early exit * tests(add): resursive add ast * tests(add): update recursive parser snaps * misc(conflicts): resolve conflicts * tests(parser): update tests, inputs * chore(review): fix some things * ast(utils): add ast-path safe traverse and type support * ast(utils): merge update property with add property * tests(ast): add tests for safe traversals * misc(fixes): review comments * tests(ast): add tests for addProperty * misc(fixes): review comments * misc(fixes): review comments * misc(fixes): review comments * cli(add): re-add add command

webpack-bot added the PR: unreviewed label Mar 11, 2018

dhruvdutt changed the title ~~Minor fixes~~ cli(entry): quotes sanitization Mar 11, 2018

webpack-bot added the PR: CI-ok label Mar 11, 2018

ematipico reviewed Mar 11, 2018

View reviewed changes

ematipico approved these changes Mar 11, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: unreviewed labels Mar 11, 2018

evenstensberg reviewed Mar 11, 2018

View reviewed changes

evenstensberg reviewed Mar 12, 2018

View reviewed changes

evenstensberg requested changes Mar 12, 2018

View reviewed changes

webpack-bot added the PR: reviewed-changes-requested label Mar 12, 2018

dhruvdutt force-pushed the minor-fixes branch from f1172cd to 147f51b Compare March 14, 2018 10:27

webpack-bot added PR: review-outdated and removed PR: reviewed-approved PR: reviewed-changes-requested labels Mar 14, 2018

dhruvdutt force-pushed the minor-fixes branch from 147f51b to c906747 Compare March 14, 2018 10:28

dhruvdutt commented Mar 14, 2018

View reviewed changes

dhruvdutt force-pushed the minor-fixes branch 3 times, most recently from 3a058ed to 51b0c72 Compare March 14, 2018 16:31

webpack-bot added PR: conflict and removed PR: CI-ok labels Apr 3, 2018

dhruvdutt force-pushed the minor-fixes branch from 51b0c72 to cbaa665 Compare April 6, 2018 16:31

webpack-bot added PR: CI-ok and removed PR: conflict labels Apr 6, 2018

evenstensberg requested changes Apr 10, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Apr 10, 2018

dhruvdutt added 6 commits April 15, 2018 17:57

chore: minor doc fixes

90269a5

cli(entry): quotes sanitization

27ffd25

tests(entry): add test case for double quotes

5e01249

tests(entry): update snapshots

9e9f162

misc(utils): entry - variable parity

2a16c43

misc(prop-types): sort

7961afb

dhruvdutt force-pushed the minor-fixes branch from cbaa665 to 0f4948d Compare April 15, 2018 12:31

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Apr 15, 2018

cli(entry): multiple entries quotes sanitization

da851a0

dhruvdutt force-pushed the minor-fixes branch from 0f4948d to da851a0 Compare April 15, 2018 12:32

evenstensberg reviewed Apr 15, 2018

View reviewed changes

evenstensberg approved these changes Apr 15, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Apr 15, 2018

ematipico approved these changes Apr 16, 2018

View reviewed changes

evenstensberg merged commit 0354db8 into webpack:master Apr 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cli(entry): quotes sanitization #337

cli(entry): quotes sanitization #337

dhruvdutt commented Mar 11, 2018 •

edited

Loading

webpack-bot commented Mar 11, 2018

ematipico Mar 11, 2018

dhruvdutt Mar 11, 2018

evenstensberg left a comment

evenstensberg Mar 12, 2018

dhruvdutt Mar 12, 2018 •

edited

Loading

ematipico Mar 12, 2018

evenstensberg left a comment

webpack-bot commented Mar 14, 2018

dhruvdutt Mar 14, 2018 •

edited

Loading

ematipico commented Apr 4, 2018

evenstensberg commented Apr 4, 2018

evenstensberg left a comment

dhruvdutt commented Apr 15, 2018

evenstensberg commented Apr 15, 2018

dhruvdutt commented Apr 15, 2018

evenstensberg left a comment

evenstensberg Apr 15, 2018

dhruvdutt Apr 15, 2018

dhruvdutt commented Apr 15, 2018 •

edited

Loading

dhruvdutt commented Apr 16, 2018

	if (
	propAns[val].charAt(0) !== "(" &&
	propAns[val].charAt(0) !== "[" &&
	propAns[val].indexOf("function") < 0 &&
	propAns[val].indexOf("path") < 0 &&
	propAns[val].indexOf("process") < 0
	) {
	propAns[val] = `"${propAns[val]}.js"`;
	}

cli(entry): quotes sanitization #337

cli(entry): quotes sanitization #337

Conversation

dhruvdutt commented Mar 11, 2018 • edited Loading

webpack-bot commented Mar 11, 2018

ematipico Mar 11, 2018

Choose a reason for hiding this comment

dhruvdutt Mar 11, 2018

Choose a reason for hiding this comment

evenstensberg left a comment

Choose a reason for hiding this comment

evenstensberg Mar 12, 2018

Choose a reason for hiding this comment

dhruvdutt Mar 12, 2018 • edited Loading

Choose a reason for hiding this comment

ematipico Mar 12, 2018

Choose a reason for hiding this comment

evenstensberg left a comment

Choose a reason for hiding this comment

webpack-bot commented Mar 14, 2018

dhruvdutt Mar 14, 2018 • edited Loading

Choose a reason for hiding this comment

ematipico commented Apr 4, 2018

evenstensberg commented Apr 4, 2018

evenstensberg left a comment

Choose a reason for hiding this comment

dhruvdutt commented Apr 15, 2018

evenstensberg commented Apr 15, 2018

dhruvdutt commented Apr 15, 2018

evenstensberg left a comment

Choose a reason for hiding this comment

evenstensberg Apr 15, 2018

Choose a reason for hiding this comment

dhruvdutt Apr 15, 2018

Choose a reason for hiding this comment

dhruvdutt commented Apr 15, 2018 • edited Loading

dhruvdutt commented Apr 16, 2018

dhruvdutt commented Mar 11, 2018 •

edited

Loading

dhruvdutt Mar 12, 2018 •

edited

Loading

dhruvdutt Mar 14, 2018 •

edited

Loading

dhruvdutt commented Apr 15, 2018 •

edited

Loading