-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to remove inconsistent CLI messaging #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Welcome to webpack. 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , thanks! 💙
Happy to help, thanks for the quick review. |
@bitpshr We use commitlint. Use |
@bitpshr Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Sweet Beans, thanks for the PR @bitpshr ! |
What kind of change does this PR introduce?
Documentation
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
Yes
Summary
This PR updates the README to remove inconsistent messaging about the old webpack CLI. See #327.
Does this PR introduce a breaking change?
No
Other information
Fixes #327