Update README to remove inconsistent CLI messaging #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dhruvdutt
approved these changes
Mar 9, 2018
dhruvdutt
approved these changes
Mar 9, 2018
, thanks! 💙
|
Happy to help, thanks for the quick review. |
|
@bitpshr We use commitlint. Use |
|
@bitpshr Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Sweet Beans, thanks for the PR @bitpshr ! |
This was referenced Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Documentation
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
Yes
Summary
This PR updates the README to remove inconsistent messaging about the old webpack CLI. See #327.
Does this PR introduce a breaking change?
No
Other information
Fixes #327