-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(migrate): move options to use #308
Conversation
c241aea
to
5002366
Compare
5002366
to
467b9ad
Compare
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm here, @fokusferit @ematipico PTAL
lib/migrate/loaders/loaders.js
Outdated
|
||
const fitOptionsToUse = p => { | ||
let options; | ||
p.value.properties.map(prop => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.map
returns a new array. If you don't assign it, it's better to use .forEach
.
lib/migrate/loaders/loaders.js
Outdated
prop => prop.key.name !== "options" | ||
); | ||
|
||
p.value.properties.map(prop => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here: .forEach
is more appropriate
@sendilkumarn Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Fixes #159
Does this PR introduce a breaking change?
Other information