Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli(taptable): Remove Tapable#apply calls #305

Merged
merged 1 commit into from
Mar 2, 2018
Merged

cli(taptable): Remove Tapable#apply calls #305

merged 1 commit into from
Mar 2, 2018

Conversation

ooflorent
Copy link
Member

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

n/a

Summary

Tapable#apply is deprecated.

Does this PR introduce a breaking change?

no

Other information

Fix #304

evenstensberg
evenstensberg approved these changes Mar 2, 2018
View reviewed changes
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm 👍

@evenstensberg evenstensberg changed the title Remove Tapable#apply calls cli(taptable): Remove Tapable#apply calls Mar 2, 2018
@evenstensberg evenstensberg merged commit 7d44f8c into webpack:master Mar 2, 2018
@webpack webpack deleted a comment from webpack-bot Mar 2, 2018
@honzajerabek
Copy link

thanks for prompt fix!

@erikdesjardins erikdesjardins mentioned this pull request Mar 4, 2018
Closed
This was referenced Mar 14, 2018
Merged
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenstensberg evenstensberg evenstensberg approved these changes

Assignees
No one assigned
Labels
PR: CI-not-ok PR: reviewed-approved PR: small
Projects
None yet
Milestone
No milestone
4 participants
@ooflorent @honzajerabek @evenstensberg @webpack-bot