-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] strict Promise configuration validation #298
Merged
evenstensberg
merged 1 commit into
webpack:master
from
jbottigliero:feature/258-Promise-configuration-validation
Mar 1, 2018
Merged
[feature] strict Promise configuration validation #298
evenstensberg
merged 1 commit into
webpack:master
from
jbottigliero:feature/258-Promise-configuration-validation
Mar 1, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba557d8
to
8750ec4
Compare
Didn't realize |
@jbottigliero You'll need to use one of these to pass commit lint and CI build. Eg. Lines 20 to 29 in 191b458
|
- updates configuration schema to use `"instanceof": "Promise"` (webpack#258) - depends on (webpack/webpack#6430)
8750ec4
to
7e57337
Compare
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
evenstensberg
approved these changes
Mar 1, 2018
totally legit 👍 |
EugeneHlushko
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"instanceof": "Promise"
(configuration validation : strict "Promise" instanceof validation #258)What kind of change does this PR introduce?
feature/refactoring
Did you add tests for your changes?
Covered by existing tests.
If relevant, did you update the documentation?
n/a
Summary
Previously, validation for
Promise
configurations passed via"instanceof": "Function"
, withwebpack@4+
(ajv-keywords@3+
), we can do strict validation on"instanceof": "Promise"
.To accommodate this change we have to change the check to
anyOf
due toPromise
passing"type": "object"
.