-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: yeoman-generator fork issue #294
Conversation
f2a7d6b
to
b050abb
Compare
b050abb
to
d0b8665
Compare
(Update): Added a temp The issue is with how prettier formats and writes our code which later eslint lints. When I think we did not catch this earlier because these files were not being changed and hence prettier or eslint might be skipping them while checks but this PR contains change in those files. I also tried using |
it fixs #291 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the eslint disables, and I can LGTM
|
@ev1stensberg Updated. 💯 |
Okay nice, so you can reimpl the disables, weird they weren't throwing earlier |
@dhruvdutt Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
@ev1stensberg Please apologies in advance, Why is yeoman necessary in this project? And also why a forked was needed? |
It's to grab arguments from a generator ( the config we're scaffolding ). The fork implements a way to do that, yeoman doesn't support it |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Isn't it possible to implement it from scratch of using another library that supports it? |
Possibly, needs investigation anyhow :( |
Is there a way to avoid the custom |
I'm having a lot to do until thursday +-, will try to get something up after that. We're gonna use yeoman, but not the fork. Right now, we avoid writing to a temp |
The reliance on the custom |
What kind of change does this PR introduce?
Fixes the issue with yeoman-generator fork. Fixes #291 🐛
yeoman-generator
module path in package.json to match the syntax recommended by npm."webpack-fork-yeoman-generator"
to"yeoman-generator"
across all files.Tests
All tests pass. 💯 Also, did a quick test with:
Summary
Also, now we don't need to published the fork separately.
Related commit (0b4269c)
Does this PR introduce a breaking change?
No