-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(grammar): revise spelling and incorrect syntax #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good here, thanks for the PR!
You need to change your commit style as well as you might have broken some logic in the binTestCases as you renamed some files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comments
@ev1stensberg: I can't understand the builder's output... |
okay so you need to rebase your commits like: |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
@ev1stensberg: thanks, that worked |
What kind of change does this PR introduce?
Spelling fixes
Did you add tests for your changes?
No. It's possible to write a test using
fchurn
, but I'm not currently providing code for that in my PRs.Summary
Misspellings are embarrassing.
Does this PR introduce a breaking change?
runSingleTransform
is a breaking change.I can provide a shim if required.
Other information
Generated by https://github.com/jsoref/spelling
f
; to maintain your repo, please considerfchurn