-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve sample migration output #281
Conversation
You need to change your commit format, change you rebase? It should be something like:
|
458d712
to
9b978f8
Compare
@ev1stensberg rebased and updated commit messages. 👍 |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
MIGRATE.md
Outdated
@@ -153,7 +153,7 @@ module.exports = { | |||
|
|||
In summary, we can see the follow changes were made | |||
1. The webpack schema for using loaders has changed | |||
- `loaders` is now `module.rules` | |||
- `module.loaders` is now `module.rules` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In webpack v1 this was loaders, please remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaned the commit containing that change.
@@ -68,23 +68,23 @@ module.exports = { | |||
The `migrate` command, when run, will show the proposed changes to the config file in the terminal, prompting the user to | |||
accept the changes or not: | |||
|
|||
```bash | |||
```diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice
+ loader: 'babel-loader' | ||
+ }], | ||
+ options: { | ||
- loader: ExtractTextPlugin.extract('style', 'css!sass') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Updated the summary image as well. 💯
@dhruvdutt Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
What kind of change does this PR introduce?
Enhancement
Summary
![image](https://user-images.githubusercontent.com/5961873/36643113-49153cb2-1a6d-11e8-90d9-52a890933816.png)
Actual output:
![image](https://user-images.githubusercontent.com/5961873/36639083-bf8685a2-1a29-11e8-9f1f-853cb2156f58.png)
Does this PR introduce a breaking change?
No