Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Show help on no command" #276

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 22, 2018

Reverts #252

It shows help way to often, even when config file was provided.

I propose to revert this change until a better solution is found.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@evenstensberg evenstensberg merged commit 4079570 into master Feb 22, 2018
dhruvdutt added a commit to dhruvdutt/webpack-cli that referenced this pull request Feb 23, 2018
Copy link
Member

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bin/webpack.js 100644 → 100755
Do we also need to change file permissions?

@evenstensberg
Copy link
Member

no

@dhruvdutt
Copy link
Member

Seems like this PR changed it. Look at files diff.
image

@evenstensberg
Copy link
Member

ls -la bin/webpack.js, nothing broke.

@ematipico ematipico deleted the revert-252-kingdaro-show-help-on-no-command branch April 8, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants