misc(refactor): reduce code duplication use process.exitCode instead of process.exit #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind checking out the failing test cases? Might be cause exitCode is async, so the tests get polluted |
evenstensberg
changed the title
EugeneHlushko
changed the title
EugeneHlushko
commented
Feb 21, 2018
bin/convert-argv.js
Outdated
| } | ||
| const isArray = Array.isArray(argv[name]); | ||
| const isSet = typeof argv[name] !== "undefined" && argv[name] !== null; | ||
| if (!isArray || !isSet) return; |
There was a problem hiding this comment.
Hmm there was wrong operator in a cond here, should be if (!isArray && !isSet) return;
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
evenstensberg
approved these changes
Feb 21, 2018
fokusferit
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
process.exitCode = 1vsprocess.exit(1)https://nodejs.org/dist/latest-v9.x/docs/api/process.html#process_process_exit_code
Did you add tests for your changes?
no
If relevant, did you update the documentation?
not relevant
Summary
Progressing in the
bindirectoryDoes this PR introduce a breaking change?
no
Other information
none