-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chore): add project tools and utilities #270
Conversation
@paulirish is it okay with you guys if we use your linting + changelog implementation? Credited you guys at every place we use code from lighthouse |
3173d78
to
db243b6
Compare
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Well done 👍
@@ -29,11 +29,15 @@ | |||
"appveyor:lint": "yarn lint", | |||
"appveyor:test": "nyc jest && yarn reportCoverage", | |||
"travis:integration": "yarn prepare && nyc jest && yarn reportCoverage", | |||
"travis:lint": "yarn lint" | |||
"travis:lint": "yarn lint && yarn bundlesize", | |||
"bundlesize": "bundlesize", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? Shouldn't yarn bundlesize
already call the bin file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another question: are we adding bundlesize so users can use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for CI's for now, we could add it to as a feature to webpack, but that needs some work
package.json
Outdated
"travis:lint": "yarn lint && yarn bundlesize", | ||
"bundlesize": "bundlesize", | ||
"commitmsg": "commitlint -e $GIT_PARAMS", | ||
"changelog": "conventional-changelog --config ./build/changelog-generator/index.js --infile changelog.md --same-file" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog.md
=> CHANGELOG.md
@ev1stensberg Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
n/a
If relevant, did you update the documentation?
n/a
Summary
Adds project utilities like commitlint, changelog
Does this PR introduce a breaking change?
Other information