feat(chore): add project tools and utilities #270
Conversation
|
@paulirish is it okay with you guys if we use your linting + changelog implementation? Credited you guys at every place we use code from lighthouse |
evenstensberg
force-pushed
the
feat/maintainance
branch
from
3173d78
to
db243b6
Compare
evenstensberg
changed the title
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
| @@ -29,11 +29,15 @@ | |||
| "appveyor:lint": "yarn lint", | |||
| "appveyor:test": "nyc jest && yarn reportCoverage", | |||
| "travis:integration": "yarn prepare && nyc jest && yarn reportCoverage", | |||
| "travis:lint": "yarn lint" | |||
| "travis:lint": "yarn lint && yarn bundlesize", | |||
| "bundlesize": "bundlesize", | |||
There was a problem hiding this comment.
Is this needed? Shouldn't yarn bundlesize already call the bin file?
There was a problem hiding this comment.
another question: are we adding bundlesize so users can use it?
There was a problem hiding this comment.
It's for CI's for now, we could add it to as a feature to webpack, but that needs some work
package.json
Outdated
| "travis:lint": "yarn lint && yarn bundlesize", | ||
| "bundlesize": "bundlesize", | ||
| "commitmsg": "commitlint -e $GIT_PARAMS", | ||
| "changelog": "conventional-changelog --config ./build/changelog-generator/index.js --infile changelog.md --same-file" |
There was a problem hiding this comment.
changelog.md => CHANGELOG.md
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
|
@ev1stensberg Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
n/a
If relevant, did you update the documentation?
n/a
Summary
Adds project utilities like commitlint, changelog
Does this PR introduce a breaking change?
Other information