-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor bin directory #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! 💙 LGTM
bin/config-yargs.js
Outdated
@@ -1,11 +1,11 @@ | |||
var CONFIG_GROUP = "Config options:"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess also these can be const
s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow how did they get through 👍
The failure doesnt look valid :/ |
Kicked a new build. Probably it's a random failure |
78cbb8a
to
aab2a71
Compare
@EugeneHlushko Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
rebased onto master just in case |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
What kind of change does this PR introduce?
Refactor bin directory to be aligned with code style according to node version support.
Did you add tests for your changes?
it is not necessary
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
no
Other information