-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: configs
property for --devtool
#2603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only for webpack v5, we already support it
I see then we should remove |
It is allowed for v4 too https://github.com/webpack/webpack/blob/webpack-4/schemas/WebpackOptions.json#L2039 |
yep, okay, let's do it, but I don't want to accept any bugfixes/features (expect security bugs for v4), because when we will drop webpack v4 we will remove these flags |
Makes sense 👍🏻 |
Codecov Report
@@ Coverage Diff @@
## master #2603 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 29 29
Lines 1480 1480
Branches 425 425
=======================================
Hits 1352 1352
Misses 128 128
Continue to review full report at Codecov.
|
/cc @webpack/cli-team |
Thanks |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
devtool
can also acceptfalse
.Does this PR introduce a breaking change?
No
Other information
None