Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --template flag for addon generator #2576

Merged
merged 5 commits into from
Mar 31, 2021
Merged

feat: add --template flag for addon generator #2576

merged 5 commits into from
Mar 31, 2021

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Mar 29, 2021 •
edited
Loading

What kind of change does this PR introduce?
Enhancement

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Yes

Summary
Add --template flag for loader and plugin commands.

Does this PR introduce a breaking change?
Nope

Other information
N/A

alexander-akait
alexander-akait previously approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix CI

@jamesgeorge007 jamesgeorge007 mentioned this pull request Mar 30, 2021
Closed
@codecov
Copy link

codecov bot commented Mar 30, 2021 •
edited
Loading

Codecov Report

Merging #2576 (b731511) into master (177dca7) will decrease coverage by 0.02%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2576      +/-   ##
==========================================
- Coverage   91.35%   91.33%   -0.03%     
==========================================
  Files          29       29              
  Lines        1469     1477       +8     
  Branches      423      424       +1     
==========================================
+ Hits         1342     1349       +7     
- Misses        127      128       +1
Impacted Files Coverage Δ
packages/generators/src/addon-generator.ts 93.18% <91.66%> (-1.27%) ⬇️
packages/generators/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177dca7...b731511. Read the comment docs.

@jamesgeorge007 jamesgeorge007 marked this pull request as ready for review March 30, 2021 11:15
@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner March 30, 2021 11:15
alexander-akait
alexander-akait previously approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team need review

alexander-akait
alexander-akait approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jamesgeorge007 jamesgeorge007 merged commit c8f702a into master Mar 31, 2021
@jamesgeorge007 jamesgeorge007 deleted the feat/addon-generator branch March 31, 2021 17:14
This was referenced Apr 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@anshumanv anshumanv anshumanv approved these changes

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jamesgeorge007 @alexander-akait @anshumanv @snitin315 @webpack-bot