-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(convert-args): remove unused arguments #253
refactor(convert-args): remove unused arguments #253
Conversation
@@ -3,7 +3,8 @@ var fs = require("fs"); | |||
fs.existsSync = fs.existsSync || path.existsSync; | |||
var interpret = require("interpret"); | |||
var prepareOptions = require("./prepareOptions"); | |||
module.exports = function(yargs, argv, convertOptions) { | |||
module.exports = function(...args) { | |||
var argv = args[1] || args[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont want to change the var
this needs to be handled across the cli 👍
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove yargs
from bin/webpack.js
L223, and bin/processOptions.js
L12? Its unused anyways.
@sendilkumarn Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
@ev1stensberg Good catch 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
fixes #250