Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Open bot to the webpack-cli #224

Merged
merged 9 commits into from
Dec 21, 2017
Merged

[Feature] Open bot to the webpack-cli #224

merged 9 commits into from
Dec 21, 2017

Conversation

ematipico
Copy link
Contributor

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary
Fixes #195

Does this PR introduce a breaking change?
No

Other information
The configuration is copied from webpack repository and adapted to the current repository. The actions that the bot will do are:

  • Adding labels CI-ok and CI-not-ok to the PRs (labels needed)
  • Reporting error if linter and tests fail
  • Reporting general error
  • Adding label PR: conflict (labels needed)
  • Adding labels unreviewed, reviewed and review-outdated to the PRs (labels needed)
  • Adding label PR: small if the PR contains small changes (label needed)
  • Adds a message if the PR is done from a branch that is master
  • Moves tasks between repos of the same organization
  • Marks inactive issues
  • Checks issues every week

I also added two new npm scripts that will be used just by the bot.

@ematipico
Copy link
Contributor Author

@ev1stensberg, @sokra New PR for the bot! Now it points to v2 and the builds are not failing.
Maybe as next step we could integrate codecov (the v1 didn't have it so I preferred to not change the code again).

@evenstensberg
Copy link
Member

Notified Sokra about this, but the github hook comes up after checks succeed, so it is already integrated, yes? @sokra mind doing a quick review? This and one other issue left for a v2 RFC

@evenstensberg
Copy link
Member

Let's take this for a spin LGTM

@evenstensberg evenstensberg merged commit 0cdf01d into webpack:v2 Dec 21, 2017
@evenstensberg evenstensberg mentioned this pull request Dec 21, 2017
evenstensberg pushed a commit that referenced this pull request Dec 21, 2017
* Added open-bot.yml configuration file for open bot, plus two npm scripts

* Added open-bot.yml configuration file for open bot, plus two npm scripts

* Updated open-bot configuration

* Added new dist command

 Added new dist command to generate a clean distribution folder

* Update travis configuration, runnable from the bot

* Updated job from 'unit' to 'integration'

* Moved to yarn and updated the matrix

* Removed 'prepublish'

* Fixed typo inside the configuration
@ematipico ematipico deleted the feature/add-open-bot-v2 branch December 21, 2017 16:08
node_js: "8"
env: JOB_PART=integration
- os: linux
node_js: "7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 is a "in development" version number. Only even version numbers are node.js version you need to test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The the versions will be stable, 8 and 6? As far as I understood webpack 4 won't support v4 anymore.
Also, are the labels required for webpack-bot? I don't see it doing anything on new PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants