-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Open bot to the webpack-cli #224
Conversation
Added new dist command to generate a clean distribution folder
@ev1stensberg, @sokra New PR for the bot! Now it points to |
Notified Sokra about this, but the github hook comes up after checks succeed, so it is already integrated, yes? @sokra mind doing a quick review? This and one other issue left for a v2 RFC |
Let's take this for a spin LGTM |
* Added open-bot.yml configuration file for open bot, plus two npm scripts * Added open-bot.yml configuration file for open bot, plus two npm scripts * Updated open-bot configuration * Added new dist command Added new dist command to generate a clean distribution folder * Update travis configuration, runnable from the bot * Updated job from 'unit' to 'integration' * Moved to yarn and updated the matrix * Removed 'prepublish' * Fixed typo inside the configuration
node_js: "8" | ||
env: JOB_PART=integration | ||
- os: linux | ||
node_js: "7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 is a "in development" version number. Only even version numbers are node.js version you need to test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The the versions will be stable, 8 and 6? As far as I understood webpack 4 won't support v4
anymore.
Also, are the labels required for webpack-bot? I don't see it doing anything on new PRs.
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Fixes #195
Does this PR introduce a breaking change?
No
Other information
The configuration is copied from
webpack
repository and adapted to the current repository. The actions that the bot will do are:CI-ok
andCI-not-ok
to the PRs (labels needed)PR: conflict
(labels needed)unreviewed
,reviewed
andreview-outdated
to the PRs (labels needed)PR: small
if the PR contains small changes (label needed)I also added two new npm scripts that will be used just by the bot.