fix: compatibility with webpack@next #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
changed the title
alexander-akait
approved these changes
Sep 1, 2020
|
Need to add tests for new |
|
@snitin315 Yes, let's do it in separate PR, we need to rc release, maybe we can write test to ensure we do not lost new flags? |
|
I can see the new flags in help output. So we haven't lost them.
|
anshumanv
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
tests
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
the latest release have breaking changes
Does this PR introduce a breaking change?
NO
Other information