Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw err when supplied config is absent #1760

Merged
merged 4 commits into from
Aug 20, 2020

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?

fix

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Should we state this somewhere?

Summary

  • throw err when requested config file is absent

Does this PR introduce a breaking change?
No

Other information
Fixes #1759

@anshumanv anshumanv requested a review from a team as a code owner August 19, 2020 13:51
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the processingMessageBuffer when you're at it

@anshumanv
Copy link
Member Author

Yeah we should get rid of all instances, unused

@anshumanv
Copy link
Member Author

Done @evenstensberg 💯

@alexander-akait
Copy link
Member

Good job!

@alexander-akait alexander-akait merged commit 86dfe51 into webpack:next Aug 20, 2020
@anshumanv anshumanv deleted the config-absent branch August 20, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Throw error when config file is absent
6 participants