-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add name flag #1757
feat: add name flag #1757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one doubt.
How name
assignment would work in case of multiple configurations through the flag you created?
yeah we should have a test with multiple config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to backport is for webpack@4? I think core flags have the name
flag
Yes this is for v4, https://v4.webpack.js.org/configuration/other-options/#name v5 already supports this via core flags @evilebottnawi |
Interesting case, ideas? |
Default behaviour right now is to apply it to all config, not sure if that's right for name |
Devtool flag applies to all the configs |
This options make sense only with single |
@snitin315 how does the core flag works in case of multiple config? |
This property module.exports = [{
name: 'first'
},
{
name: 'second'
},
{
name: 'third'
}] In case if you don't provide |
I think we need discussion about multiple configurations and flags, what is the logic now? |
I think right now we support -
|
Here interesting case, some options can't be overridden when you have multiple configurations, for example |
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's open an issue about forbidden flags for multiple compilations and implement it in the other PR
alias: "i", | ||
description: "Use webpack interactively", | ||
group: BASIC_GROUP | ||
} */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should focus on this after release too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
/cc @webpack/cli-team need review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Add name flag.
Does this PR introduce a breaking change?
No
Other information