fix: use appropriate exit codes #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
Aug 18, 2020
|
/cc @webpack/cli-team |
anshumanv
approved these changes
Aug 18, 2020
|
Seems good @snitin315, just run a check once more that we're covering all the exit code statements to prevent unnecessary follow up for the same thing. |
rishabh3112
approved these changes
Aug 19, 2020
I did a check again, these were the only places I was able to found via GitHub search. Though it might be possible that I have missed some places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix, docs,
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Use appropriate exit codes and document their meanings.
Does this PR introduce a breaking change?
No
Other information
NA