-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --config-name flag #1753
Conversation
I think it makes sense to add multiple config support using flags first. |
https://webpack.js.org/configuration/configuration-types/#exporting-multiple-configurations |
615a477
to
7aedac7
Compare
@@ -117,6 +118,14 @@ class ConfigGroup extends GroupHelper { | |||
const newOptions = configOptions(formattedEnv, argv); | |||
// When config function returns a promise, resolve it, if not it's resolved by default | |||
newOptionsObject['options'] = await Promise.resolve(newOptions); | |||
} else if (Array.isArray(configOptions) && this.args.configName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment when this block is executed, can give example, looks good otherwise
7aedac7
to
a41941e
Compare
This |
@snitin315 maybe we should update |
I think it's setup externally, not defined in the workflow file. @evenstensberg do you know how it's setup? |
It seems we're relying on commitlint-bot which is not maintained anymore, it is advised to use semantic-pull-requests instead. |
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Addition of
--config-name
flag.Does this PR introduce a breaking change?
No
Other information
Fixes #1657