chore: remove --mode flag validation #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (this.args.mode !== PRODUCTION && this.args.mode !== DEVELOPMENT && this.args.mode !== NONE) { | ||
| logger.warn('You provided an invalid value for "mode" option. Using "production" by default'); | ||
| return PRODUCTION; | ||
| } | ||
| return this.args.mode; | ||
| } | ||
| return PRODUCTION; |
There was a problem hiding this comment.
We even simplify - just set mode only when it passed, webpack itself set production by default
snitin315
force-pushed
the
chore/mode-validation
branch
from
ac23e05
to
1bc4298
Compare
evenstensberg
approved these changes
Aug 17, 2020
alexander-akait
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
chore
Did you add tests for your changes?
YES
If relevant, did you update the documentation?
NA
Summary
webpack already validates the config. No need to do double work.
Does this PR introduce a breaking change?
NO
Other information