-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: do not spawn new process for running webpack #1741
Conversation
Do you need help with tests? |
Yes, I'm helping with the node flags support. I will push changes soon. |
Using NODE_OPTIONS gives desired behavior with |
I think we should remove |
Yeah we can remove, also doing unnecessary parsing |
Let's do it here 👍 |
Okay, on it |
Here we improve starting webpack around 50-200ms on different computers (already tested), it is very good improvements |
Thanks for the benchmark! |
CI freeze 😞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
/cc @webpack/cli-team need review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Something wrong with commitlint 😞 |
@anshumanv Don't worry about |
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Not yet
If relevant, did you update the documentation?
No
Summary
Do not spawn new process for running the CLI
Does this PR introduce a breaking change?
Shouldn't
Other information