fix: conditionally install terser-webpack-plugin for webpack@next #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipped in stable 👍 |
|
Yep, it should be skipped for stable |
snitin315
approved these changes
Aug 4, 2020
|
@snitin315 had to include your optimization tests else CI fail 😄 |
alexander-akait
approved these changes
Aug 4, 2020
|
We need to remove it after the next beta release, please update other PRs, thanks |
|
Will remove once released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
No
If relevant, did you update the documentation?
NA
Summary
Conditionally install terser plugin for webpack@next
Does this PR introduce a breaking change?
No
Other information
#1731 (comment)