-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for .cjs config #1727
Conversation
@@ -42,6 +42,16 @@ const getDefaultConfigFiles = () => { | |||
|
|||
const getConfigInfoFromFileName = (filename) => { | |||
const fileMetaData = parse(filename); | |||
// .cjs is not available on interpret side, handle it manually for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evilebottnawi check https://github.com/gulpjs/interpret/blob/57cd5973c313c420b1ad24a922d1c95ebec3c532/index.js#L181 doesn't have .cjs
hence need manual handling
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Not yet
Summary
Does this PR introduce a breaking change?
No
Other information