fix: supply argv to config with functions

[anshumanv]

What kind of change does this PR introduce?

fix

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
NA

Summary

• Pass argv to config function

Does this PR introduce a breaking change?
No

Other information
Fixes #1704
Fixes #1126

[alexander-akait]

Good job!

[webpack-bot]

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

[milizhang]

I think this does not actually work - while it seems like the arguments now can be passed to config function, when you actually tries to pass custom arguments, user will stuck at "Which flags do you want to use", likely as the custom argument is unknown to the cli.

[anshumanv]

@milizhang can you give example?

[milizhang]

@anshumanv Please take a look at this: https://github.com/milizhang/webpack-cli-4-argv-repro

If you use webpack-cli 3, console.log(argv.testArg); will give you "Test" if you run webpack --testArg=Test, while webpack-cli 4 will stuck asking you to clarify which argument you want to place. (Unless it is an argument that already exists in core webpack).

[anshumanv]

Yep unknown arguments are not registered, you should use --env for it

[milizhang]

Is this something that webpack-cli explicitly decided to deprecate in V4? Are there anyway to register custom arguments in configurations?

[anshumanv]

Is this something that webpack-cli explicitly decided to deprecate in V4? Are there anyway to register custom arguments in configurations?

Yes, passing arbitrary values was deprecated. You should be able to achieve it using --env or does it not fit your use case?

You can just do -

--env testArg=test

env = { testArg: 'test' } // in config 

[milizhang]

Got it. Picking custom argv over env was more of a preference issue. Since it is deprecated I will move toward env.

Thanks for the info.